Skip to content

Conversation

@maarten-ic
Copy link
Collaborator

Add a list of quantities that should get a sign flip on conversion, but are not covered by the generic rule that looks at DD3 cocos_label_transformation metadata.

Fixes #61

Add a list of quantities that should get a sign flip on conversion, but are not covered by the generic rule that looks at DD3 `cocos_label_transformation` metadata.
Copy link
Collaborator

@olivhoenen olivhoenen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe @imbeauf can check and confirm the list of paths for sign flip?
E.g. is ggd/psi/coefficients also affected?

@imbeauf
Copy link

imbeauf commented Sep 26, 2025

I confirm the list, but for the GGD coefficients ggd/psi/coefficients. We have no a priori definition of these coefficients, so there is no guarantee that changing their sign will simply change the sign of the evaluated psi.
I would suggest not to introduce any transformation for those, to avoid the risk of introducing potential errors.

@olivhoenen olivhoenen merged commit e2195e4 into iterorganization:develop Sep 26, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No sign flip of equilibrium.time_slice[].boundary.psi upon conversion from DDv3 to DDv4

4 participants