-
Notifications
You must be signed in to change notification settings - Fork 14
[GH#59] Convert name/identifier(DD3) to description/name(DD4) #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH#59] Convert name/identifier(DD3) to description/name(DD4) #68
Conversation
|
Great, thank you @dee-mew. There are some code style issues raised by the linter, please check https://imas-python.readthedocs.io/en/stable/code_style.html#code-style-and-linting and fix them. |
deb2c17 to
dd2ca25
Compare
|
@olivhoenen : Resolved the lint warnings |
dd2ca25 to
e382589
Compare
maarten-ic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Deepak! Thanks for preparing this, it looks to be working great. I've left a couple of comments to improve the code: please have a look at them and feel free to send me a message on Slack if anything is unclear.
Best,
Maarten
|
@dee-mew Can you also update the documentation (https://imas-python.readthedocs.io/en/latest/multi-dd.html) and add this new DD3 to DD4 conversion rule? |
Signed-off-by: Deepak Mewar <[email protected]>
e382589 to
14afe29
Compare
@maarten-ic Updated documentation |
106cdef to
842cde1
Compare
Hi @maarten-ic Thanks for the review. I have updated the PR to address your review comments. |
Signed-off-by: Deepak Mewar <[email protected]>
maarten-ic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dee-mew!
Code is tested with the attached script.
test_issue59.py
Test output log attached.
testresult_issue59.txt
Also tested with
"imas:hdf5?path=/work/imas/shared/imasdb/ITER_MD/3/150100/5"Test result attached.
testresult_issue59_magnetics_150100_5.txt
[INPUT]
[OUTPUT]