test: capture stdout/stderr in Bash.test helper #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `Bash.test` helper did not capture stdout or stderr, causing them to be None. This meant that the assertion `not stdout` was always true (vacuously), and if a test failed, the error message contained no output. Changed the assertion and also the assertion failure message to not hide the "None/None" issue. This commit adds output capturing to `subprocess.Popen` and decodes it as utf-8, ensuring that test failures provide useful debugging information.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
=======================================
Coverage 89.18% 89.18%
=======================================
Files 3 3
Lines 370 370
=======================================
Hits 330 330
Misses 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Brought to you by google antigravity. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
Bash.testhelper did not capture stdout or stderr,causing them to be None. This meant that the assertion
not stdoutwas always true (vacuously), and if a test failed, the error message
contained no output.
Changed the assertion and also the assertion failure message to not
hide the "None/None" issue.
This commit adds output capturing to
subprocess.Popenand decodesit as utf-8, ensuring that test failures provide useful debugging
information.