Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index: collect: ignore loading errors in collected index #495

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Jan 2, 2024

Once we've collected stuff from original indexes, we don't really care about index loading errors and can safely ignore them.

Once we've collected stuff from original indexes, we don't really
care about index loading errors and can safely ignore them.
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9039534) 63.58% compared to head (05c987a) 63.58%.

Files Patch % Lines
src/dvc_data/index/collect.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #495   +/-   ##
=======================================
  Coverage   63.58%   63.58%           
=======================================
  Files          61       61           
  Lines        4193     4196    +3     
  Branches      715      715           
=======================================
+ Hits         2666     2668    +2     
- Misses       1381     1382    +1     
  Partials      146      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efiop efiop merged commit 656326e into iterative:main Jan 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants