apply: remove latest_only, remove nested progress bar #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes `latest_only` since it's only used in a single place, and it feels more like a `diff`/`compare` than `apply`. Also, makes the progressbar logic simpler and avoids nesting of the callbacks.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
==========================================
+ Coverage 63.70% 63.74% +0.03%
==========================================
Files 61 61
Lines 4177 4173 -4
Branches 714 713 -1
==========================================
- Hits 2661 2660 -1
+ Misses 1368 1367 -1
+ Partials 148 146 -2 ☔ View full report in Codecov by Sentry. |
efiop
approved these changes
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
latest_onlysince it's only used in a single place, and it feels more like adiff/comparethanapply. Also, makes the progress bar logic simpler and avoids nesting of the callbacks (theapplygets a callback forcreate_filesand creates one internally fordiff).Note, this does hardcore
TqdmCallbackexplicitly, but we were doing that before in practice already. I have some plans to get rid of this soon by introducing a callback factory for now.Diff is messed up due to indentation. Use this link for better diff:
https://github.com/iterative/dvc-data/pull/486/files?w=1