Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index: md5: handle missing files and cloud versioned files missing version_id #485

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Dec 22, 2023

For the record, there will be a higher level test in dvc, but I'll likely come back to adding more to dvc-data as well.

@efiop efiop merged commit a535b4b into iterative:main Dec 22, 2023
13 of 15 checks passed
@codecov-commenter
Copy link

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (31a65d7) 63.83% compared to head (c7bca3b) 63.70%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/dvc_data/index/index.py 14.28% 5 Missing and 1 partial ⚠️
src/dvc_data/index/save.py 50.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
- Coverage   63.83%   63.70%   -0.13%     
==========================================
  Files          61       61              
  Lines        4164     4177      +13     
  Branches      712      714       +2     
==========================================
+ Hits         2658     2661       +3     
- Misses       1358     1368      +10     
  Partials      148      148              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants