Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: fix benchmark for reflink #469

Merged
merged 1 commit into from
Dec 6, 2023
Merged

benchmark: fix benchmark for reflink #469

merged 1 commit into from
Dec 6, 2023

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Dec 6, 2023

Now we create tmpdir inside .pytest_cache directory and run the test there, same as we do in dvc-objects.
We probably should write similar tests in dvc, as most of our tests run in tmpdir which is usually tmpfs in linux.

Now we create tmpdir inside .pytest_cache directory and run the test there,
same as we do in dvc-objects.
We probably should write similar tests in dvc, as most of our tests run in
tmpdir which is usually tmpfs in linux.
@codecov-commenter
Copy link

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (45c8588) 63.79% compared to head (910e9b8) 63.73%.

Files Patch % Lines
tests/benchmarks/test_checkout.py 37.50% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
- Coverage   63.79%   63.73%   -0.06%     
==========================================
  Files          61       61              
  Lines        4118     4128      +10     
  Branches      706      708       +2     
==========================================
+ Hits         2627     2631       +4     
- Misses       1345     1351       +6     
  Partials      146      146              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skshetry skshetry merged commit e98e331 into main Dec 6, 2023
13 of 14 checks passed
@skshetry skshetry deleted the fix-benchmark branch December 6, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants