index: only iterate over trie items once #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmrowla
commented
Nov 30, 2023
| @@ -687,8 +687,9 @@ def _load(self, key, entry): | |||
| self._trie.commit() | |||
|
|
|||
| def load(self, **kwargs): | |||
| for key, entry in self.iteritems(shallow=True, **kwargs): | |||
| self._load(key, entry) | |||
| kwargs["shallow"] = True | |||
There was a problem hiding this comment.
this would cause an error before if someone called load(shallow=True)
pmrowla
commented
Nov 30, 2023
Comment on lines
+722
to
+724
| for key, entry in self._trie.items(prefix=prefix, shallow=shallow): | ||
| self._load(key, entry) | ||
|
|
||
| yield from self._trie.items(**kwargs) | ||
| yield key, entry |
There was a problem hiding this comment.
sqltrie items() allows for loading children during iteration now so we do not need to iterate over the trie twice
pmrowla
force-pushed
the
index-iteritems
branch
from
8b17d55
to
f4d0fac
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
==========================================
- Coverage 63.81% 63.80% -0.01%
==========================================
Files 61 61
Lines 4118 4117 -1
Branches 706 706
==========================================
- Hits 2628 2627 -1
Misses 1344 1344
Partials 146 146 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.