feat(cli): enhance dataset listing with additional options for studio #561
+197
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, the following variation are available to list datasets instead of `datachain ls-datasets`: - `datachain datasets --local` - `datachain datasets --studio` - `datachain datasets --all` (Default option) - `datachain datasets --team TEAM_NAME` - `datachain datasets` By default, if the user has logged in to Studio using `datachain studio login`, it will try to fetch the datasets from both local and studio. If any specific option (local or studio) is passed, only that option is passed. The team name is parsed from config (Set by `datachain studio team <TEAM_NAME>`). The same feature is added for `datachain ls` function and added the error handling for each scenarios. Relates to #10774
Deploying datachain-documentation with
|
| Latest commit: |
cab2f8b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b08cadfd.datachain-documentation.pages.dev |
| Branch Preview URL: | https://amrit-extend-cli-to-studio.datachain-documentation.pages.dev |
mattseddon
reviewed
Nov 4, 2024
| **kwargs, | ||
| ): | ||
| if config is None: | ||
| from .config import Config | ||
| token = Config().read().get("studio", {}).get("token") |
There was a problem hiding this comment.
[I] Both ls and datasets now run the same logic to determine whether or not to call the local or studio flavour of their underlying commands. Can you pull-out the duplication, please?
[C] I would also say that IMO the default should be to reach out to Studio only if the studio or all flag is passed. Forget about the auto-token magic.
I would also say that if all is passed that we want to display a table instead of two lists:
| name | version | studio | local |
|---|---|---|---|
| cats | 1 | ✅ | ❌ |
| cats | 2 | ✅ | ❌ |
| dogs | 1 | ✅ | ✅ |
That way I can easily check the discrepancies between the two. Instead of manually having to compare the two lists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the following variation are available to list datasets
instead of
datachain ls-datasets:datachain datasets --localdatachain datasets --studiodatachain datasets --all(Default option)datachain datasets --team TEAM_NAMEdatachain datasetsBy default, if the user has logged in to Studio using
datachain studio login,it will try to fetch the datasets from both local and studio.
If any specific option (local or studio) is passed, only that option is
passed.
The team name is parsed from config (Set by
datachain studio team <TEAM_NAME>).The same feature is added for
datachain lsfunction and added theerror handling for each scenarios.
Relates to #10774