Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): hf test can be flakey if runs in parallel #559

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

shcheklein
Copy link
Member

Per #555 (comment)

Run HF test only once since it using actual API, token, etc. It can be expensive + it seems it might be running into some race condition (not sure yet, we can observe and do retries if needed if we see that it is still unstable)

Copy link

cloudflare-workers-and-pages bot commented Nov 4, 2024

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 675fd7a
Status: ✅  Deploy successful!
Preview URL: https://2be0a115.datachain-documentation.pages.dev
Branch Preview URL: https://fix-hf-example-flakey-test.datachain-documentation.pages.dev

View logs

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.87%. Comparing base (4f0713d) to head (675fd7a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #559   +/-   ##
=======================================
  Coverage   87.87%   87.87%           
=======================================
  Files          96       96           
  Lines        9873     9873           
  Branches     1349     1349           
=======================================
  Hits         8676     8676           
  Misses        857      857           
  Partials      340      340           
Flag Coverage Δ
datachain 87.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shcheklein shcheklein merged commit db4862e into main Nov 4, 2024
38 checks passed
@shcheklein shcheklein deleted the fix-hf-example-flakey-test branch November 4, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants