Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guarantee order if order_by directly precedes collect in a chain #558

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Nov 4, 2024

Follow up to #518. More specifically this comment.

@mattseddon mattseddon self-assigned this Nov 4, 2024
Copy link

cloudflare-workers-and-pages bot commented Nov 4, 2024

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 68ccb79
Status: ✅  Deploy successful!
Preview URL: https://1123946b.datachain-documentation.pages.dev
Branch Preview URL: https://order-collect.datachain-documentation.pages.dev

View logs

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.89%. Comparing base (c2f8e89) to head (68ccb79).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #558      +/-   ##
==========================================
+ Coverage   87.87%   87.89%   +0.01%     
==========================================
  Files          96       96              
  Lines        9873     9888      +15     
  Branches     1349     1350       +1     
==========================================
+ Hits         8676     8691      +15     
  Misses        857      857              
  Partials      340      340              
Flag Coverage Δ
datachain 87.83% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattseddon mattseddon force-pushed the order-collect branch 2 times, most recently from 3f6b693 to d23ff01 Compare November 4, 2024 00:50
@mattseddon mattseddon marked this pull request as ready for review November 4, 2024 01:02
@mattseddon mattseddon requested a review from a team November 4, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant