Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove image top level import by default #31

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

shcheklein
Copy link
Member

@shcheklein shcheklein commented Jul 13, 2024

Followup #23 . I think it breaks tests in Studio since import datachain now raises exception if torch is not installed.

Need more research if this is a proper fix. This is more for awareness.

@mattseddon
Copy link
Member

I will separate image and text as per the OP:

from datachain.image import convert_images, ImageFile
from datachain.text import convert_text, 

@shcheklein
Copy link
Member Author

Thanks @mattseddon !

@mattseddon mattseddon removed their request for review July 14, 2024 23:35
@mattseddon mattseddon marked this pull request as ready for review July 15, 2024 00:01
@mattseddon mattseddon merged commit d5cfe2c into main Jul 15, 2024
10 checks passed
@mattseddon mattseddon deleted the fix-default-import branch July 15, 2024 00:02
@dberenbaum dberenbaum mentioned this pull request Jul 15, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants