-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin): miscellaneous #6
Conversation
Update from master
- refactoring
@cmurczek as Docker is a requirement for running tests now, you may have to switch to the Azure DevOps |
|
@DanielHabenicht thanks for the effort! A couple of things though to consider when submitting a PR:
Please refactor this PR so I can accept the individual parts without your changes regarding available docker images for testing. I already solved that by stubbing the dependency during tests altogether. |
Hi, thanks for maintaining this repo. I will however not refactor the tests. |
Add ability to use this plugin multiple times in one config IMPROVE: Add ability to push multiple docker images #4
Add new Option to NOT push the version tag IMPROVE: Add new Option to NOT push the version tag #5
Add some more test cases
Add Check in verifyConditions to check if image exists on machine
closes: #4 #5