Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMPROVE: Add new Option to NOT push the version tag #5

Open
DanielHabenicht opened this issue Apr 9, 2019 · 2 comments
Open

IMPROVE: Add new Option to NOT push the version tag #5

DanielHabenicht opened this issue Apr 9, 2019 · 2 comments

Comments

@DanielHabenicht
Copy link
Contributor

DanielHabenicht commented Apr 9, 2019

Add a configuration option to prevent the automatic push of the current version tag.
Instead just use the additionalTags

Draft:

...
 "prepare": {
    "path": "@iteratec/semantic-release-docker",
    "additionalTags": ["test", "demo"],
    "imageName": "my-image",
    "registryUrl": "my-private-registry:5678",
    "respositoryName": "my-repository",
    /* New optional parameter, default value: true */
    "pushVersionTag": false
  },
...

PS: I will provide a PR shortly.

DanielHabenicht added a commit to DanielHabenicht/semantic-release-docker that referenced this issue Apr 10, 2019
@cmurczek-it
Copy link
Member

Could you describe a scenario in which you would use the plugin to version the image, but then decide not to publish the version? At the moment I can't think of one...

If we add this, it would be a new feature of the plugin so there should be a feat commit in the PR.

@DanielHabenicht
Copy link
Contributor Author

My use case is caching during the release, like here:

https://github.com/DanielHabenicht/phonebook/blob/5246197fb74d0f09cfe75351bb63a0cfbc0eef3f/Phonebook.Frontend/.releaserc.json#L40-L45

In order to not push the builder image with each version but just one tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants