Skip to content

Commit

Permalink
Add editor versioning preferences. Fix #15137.
Browse files Browse the repository at this point in the history
  • Loading branch information
dkocher committed May 15, 2024
1 parent c2e90bd commit 0123f72
Show file tree
Hide file tree
Showing 81 changed files with 13,642 additions and 10,397 deletions.
Binary file modified i18n/src/main/resources/ar.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/ar.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/bg.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/bg.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/ca.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/ca.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/cs.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/cs.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/cy.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/cy.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/da.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/da.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/de.lproj/Preferences.strings
Binary file not shown.
432 changes: 257 additions & 175 deletions i18n/src/main/resources/de.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/el.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/el.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/en.lproj/Preferences.strings
Binary file not shown.
261 changes: 171 additions & 90 deletions i18n/src/main/resources/en.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/es.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/es.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/et.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/et.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/fi.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/fi.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/fr.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/fr.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/he.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/he.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/hr.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/hr.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/hu.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/hu.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/it.lproj/Preferences.strings
Binary file not shown.
439 changes: 261 additions & 178 deletions i18n/src/main/resources/it.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/ja.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/ja.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/ka.lproj/Preferences.strings
Binary file not shown.
436 changes: 259 additions & 177 deletions i18n/src/main/resources/ka.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/ko.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/ko.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/lv.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/lv.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/nl.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/nl.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/no.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/no.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/pl.lproj/Preferences.strings
Binary file not shown.
474 changes: 286 additions & 188 deletions i18n/src/main/resources/pl.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/pt_BR.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/pt_BR.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/pt_PT.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/pt_PT.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/ro.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/ro.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/ru.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/ru.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/sk.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/sk.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/sl.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/sl.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/sr.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/sr.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/sv.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/sv.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/ta_IN.lproj/Preferences.strings
Binary file not shown.
442 changes: 267 additions & 175 deletions i18n/src/main/resources/ta_IN.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/th.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/th.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/tr.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/tr.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/uk.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/uk.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/zh_CN.lproj/Preferences.strings
Binary file not shown.
440 changes: 261 additions & 179 deletions i18n/src/main/resources/zh_CN.lproj/Preferences.xib

Large diffs are not rendered by default.

Binary file modified i18n/src/main/resources/zh_TW.lproj/Preferences.strings
Binary file not shown.
438 changes: 260 additions & 178 deletions i18n/src/main/resources/zh_TW.lproj/Preferences.xib

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,21 @@ public void defaultEditorCheckboxClicked(final NSButton sender) {
preferences.setProperty("editor.alwaysUseDefault", enabled);
}

@Outlet
private NSButton editorVersioningCheckbox;

public void setEditorVersioningCheckbox(final NSButton b) {
this.editorVersioningCheckbox = b;
this.editorVersioningCheckbox.setTarget(this.id());
this.editorVersioningCheckbox.setAction(Foundation.selector("editorVersioningCheckboxClicked:"));
this.editorVersioningCheckbox.setState(preferences.getBoolean("editor.upload.file.versioning") ? NSCell.NSOnState : NSCell.NSOffState);
}

public void editorVersioningCheckboxClicked(final NSButton sender) {
boolean enabled = sender.state() == NSCell.NSOnState;
preferences.setProperty("editor.upload.file.versioning", enabled);
}

@Outlet
private NSPopUpButton bookmarkSizePopup;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ internal interface IPreferencesView : IView
bool AlwaysUseDefaultEditor { set; get; }
bool ShowHiddenFiles { set; get; }
bool DoubleClickEditor { set; get; }
bool EnableVersioning { get; set; }
bool ReturnKeyRenames { set; get; }
bool InfoWindowShowsCurrentSelection { set; get; }
int BookmarkSize { set; get; }
Expand Down Expand Up @@ -155,6 +156,7 @@ internal interface IPreferencesView : IView
event VoidHandler DefaultEditorChangedEvent;
event VoidHandler RepopulateEditorsEvent;
event VoidHandler AlwaysUseDefaultEditorChangedEvent;
event VoidHandler EnableVersioningChangedEvent;
event VoidHandler ChmodDownloadChangedEvent;
event VoidHandler ChmodDownloadUseDefaultChangedEvent;
event VoidHandler ChmodDownloadTypeChangedEvent;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ private PreferencesController(IPreferencesView view)
View.AlwaysUseDefaultEditorChangedEvent += View_AlwaysUseDefaultEditorChangedEvent;
View.ShowHiddenFilesChangedEvent += View_ShowHiddenFilesChangedEvent;
View.DoubleClickEditorChangedEvent += View_DoubleClickEditorChangedEvent;
View.EnableVersioningChangedEvent += View_EnableVersioningChangedEvent;
View.ReturnKeyRenamesChangedEvent += View_ReturnKeyRenamesChangedEvent;
View.InfoWindowShowsCurrentSelectionChangedEvent += View_InfoWindowShowsCurrentSelectionChangedEvent;
View.AlternatingRowBackgroundChangedEvent += View_AlternatingRowBackgroundChangedEvent;
Expand Down Expand Up @@ -823,6 +824,11 @@ private void View_DoubleClickEditorChangedEvent()
PreferencesFactory.get().setProperty("browser.doubleclick.edit", View.DoubleClickEditor);
}

private void View_EnableVersioningChangedEvent()
{
PreferencesFactory.get().setProperty("editor.upload.file.versioning", View.EnableVersioning);
}

private void View_ReturnKeyRenamesChangedEvent()
{
PreferencesFactory.get().setProperty("browser.enterkey.rename", View.ReturnKeyRenames);
Expand Down Expand Up @@ -978,6 +984,7 @@ private void Init()

PopulateAndSelectEditor();
View.AlwaysUseDefaultEditor = PreferencesFactory.get().getBoolean("editor.alwaysUseDefault");
View.EnableVersioning = PreferencesFactory.get().getBoolean("editor.upload.file.versioning");

#endregion

Expand Down
7,501 changes: 3,784 additions & 3,717 deletions windows/src/main/csharp/ch/cyberduck/ui/winforms/PreferencesForm.Designer.cs

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,12 @@ public bool DoubleClickEditor
set { doubleClickEditorCheckbox.Checked = value; }
}

public bool EnableVersioning
{
get => versioningCheckbox.Checked;
set => versioningCheckbox.Checked = value;
}

public bool ReturnKeyRenames
{
get { return returnKeyCheckbox.Checked; }
Expand Down Expand Up @@ -762,6 +768,7 @@ public bool DebugLog
public event VoidHandler RepopulateEditorsEvent = delegate { };
public event VoidHandler AlwaysUseDefaultEditorChangedEvent = delegate { };
public event VoidHandler ChmodDownloadChangedEvent = delegate { };
public event VoidHandler EnableVersioningChangedEvent = delegate { };
public event VoidHandler ChmodDownloadUseDefaultChangedEvent = delegate { };
public event VoidHandler ChmodDownloadTypeChangedEvent = delegate { };
public event VoidHandler DownloadOwnerReadChangedEvent = delegate { };
Expand Down Expand Up @@ -1644,5 +1651,10 @@ private void cryptomatorUseKeychain_CheckedChanged(object sender, EventArgs e)
{
CryptomatorUseKeychainChangedEvent();
}

private void versioningCheckbox_CheckedChanged(object sender, EventArgs e)
{
EnableVersioningChangedEvent();
}
}
}

0 comments on commit 0123f72

Please sign in to comment.