-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Windows link library dependency #174
Conversation
Fixes an error when building with CMAKE_LINK_LIBRARIES_ONLY_TARGETS enabled.
@triplef Could you take a look at the build logs here? https://github.com/itay-grudev/SingleApplication/actions/runs/6148176169/job/16681411832?pr=174
|
I think it might be because the MSVC environment was not set up before running CMake. I just pushed a potential fix, would be great if you can run it again. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like this change.
I apologize for the late response. Merging it now. |
Fixes an error when building with
CMAKE_LINK_LIBRARIES_ONLY_TARGETS
enabled.