Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Windows link library dependency #174

Merged
merged 4 commits into from
Sep 17, 2023

Conversation

triplef
Copy link
Contributor

@triplef triplef commented Sep 11, 2023

Fixes an error when building with CMAKE_LINK_LIBRARIES_ONLY_TARGETS enabled.

Fixes an error when building with CMAKE_LINK_LIBRARIES_ONLY_TARGETS enabled.
itay-grudev
itay-grudev previously approved these changes Sep 11, 2023
@itay-grudev
Copy link
Owner

itay-grudev commented Sep 11, 2023

@triplef Could you take a look at the build logs here?

https://github.com/itay-grudev/SingleApplication/actions/runs/6148176169/job/16681411832?pr=174

CMake Error at CMakeLists.txt:41 (find_library):
  Could not find advapi32_LIBRARY using the following names: advapi32

-- Configuring incomplete, errors occurred!

MSBuild version 17.7.2+d6990bcfa for .NET Framework
MSBUILD : error MSB1009: Project file does not exist.
Switch: ALL_BUILD.vcxproj
Error: Process completed with exit code 1.

@triplef
Copy link
Contributor Author

triplef commented Sep 11, 2023

I think it might be because the MSVC environment was not set up before running CMake. I just pushed a potential fix, would be great if you can run it again. 🙏

Copy link
Collaborator

@Shatur Shatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this change.

@itay-grudev
Copy link
Owner

I apologize for the late response. Merging it now.

@itay-grudev itay-grudev merged commit d815ce3 into itay-grudev:master Sep 17, 2023
9 checks passed
@triplef triplef deleted the patch-1 branch September 17, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants