Use AppImage path for hash when running as AppImage. #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an application is launched as AppImage, each instance is launched from its own FUSE-mounted filesystem, so each instance has its own executable path. The AppImage runtime sets the environment variable APPIMAGE to the absolute path to the .AppImage file, so we can use the content of this variable instead of QApplication::applicationFilePath() when set. Closes itay-grudev#77, itay-grudev#137
Shatur
reviewed
Sep 20, 2021
Co-authored-by: Hennadii Chernyshchyk <[email protected]>
Shatur
reviewed
Sep 20, 2021
Co-authored-by: Hennadii Chernyshchyk <[email protected]>
itay-grudev
previously approved these changes
Sep 20, 2021
|
Should we check this variable only on Linux? Maybe use |
|
@Shatur I was also thinking whether we should append |
|
Sounds good to me! |
|
On second thought I'm not sure about adding application path to the end :) |
|
@Shatur I added the |
Shatur
reviewed
Sep 20, 2021
Co-authored-by: Hennadii Chernyshchyk <[email protected]>
Shatur
previously approved these changes
Sep 20, 2021
Shatur
approved these changes
Sep 20, 2021
itay-grudev
approved these changes
Sep 20, 2021
|
Awesome! Thanks @mklein-de! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an application is launched as AppImage, each instance is launched
from its own FUSE-mounted filesystem, so each instance has its own
executable path.
The AppImage runtime sets the environment variable APPIMAGE to the
absolute path to the .AppImage file, so we can use the content of this
variable instead of QApplication::applicationFilePath() when set.
Closes #77, #137