Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dev #234

Merged
merged 6 commits into from
Jan 22, 2024
Merged

fix dev #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8f5c500
fix: pass state to proxy home
damikael Oct 17, 2023
1418aa2
v.3.18.3
damikael Oct 18, 2023
2134cdc
Update Setup.php
LDAV Oct 19, 2023
73c69d9
Merge pull request #224 from LDAV/patch-4
damikael Oct 27, 2023
b45f330
Update composer.json
damikael Oct 27, 2023
7f3fa45
upd ResponseHandler.php
damikael Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"config": {
"version": "3.18.3",
"version": "3.18.4",
"allow-plugins": {
"simplesamlphp/composer-module-installer": true
}
Expand Down
4 changes: 2 additions & 2 deletions lib/ResponseHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ protected function makeJWS($payload, $exp_time, $iss, $aud, $jwk_pem): string {
'data' => $payload, // Authentication Data
];

if(array_key_exists('fiscalNumber', $payload)) { // Subject - fiscalNumber, only if exists
if(is_array($payload) && array_key_exists('fiscalNumber', $payload)) { // Subject - fiscalNumber, only if exists
$data['sub'] = $payload['fiscalNumber'];
}

Expand All @@ -119,4 +119,4 @@ protected function makeJWS($payload, $exp_time, $iss, $aud, $jwk_pem): string {

return $token;
}
}
}
12 changes: 6 additions & 6 deletions setup/Setup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,11 +658,11 @@ public static function setup(Event $event) {
"logo"=> "/assets/img/logo.png",
"client_id"=> $proxyClientID,
"client_secret"=> $proxyClientSecret,
"level": 2,
"atcs_index": 0,
"handler": "Plain",
"response_attributes_prefix": ""
"redirect_uri"=> [$proxyRedirectURI]
"level" => 2,
"atcs_index" => 0,
"handler" => "Plain",
"response_attributes_prefix" => "",
"redirect_uri"=> [$proxyRedirectURI],
)
),
'signProxyResponse'=> $signProxyResponse,
Expand Down Expand Up @@ -1725,7 +1725,7 @@ public static function remove() {
* @param $config
* @return array
*/
private static function proxyVariables($config): array {
private static function proxyVariables($config) {
return array(
"{{SDKHOME}}" => $config['installDir'],
"{{PROXY_CLIENT_CONFIG}}" => var_export($config['proxyConfig'], true),
Expand Down