Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

authorization: implement new serviceAccounts field #1402

Merged
merged 1 commit into from
Jan 8, 2025
Merged

authorization: implement new serviceAccounts field #1402

merged 1 commit into from
Jan 8, 2025

Conversation

howardjohn
Copy link
Member

@howardjohn howardjohn commented Dec 19, 2024 •
edited
Loading

Implement istio/api#3340

@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label Dec 19, 2024
@istio-testing
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-testing istio-testing added do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 19, 2024
@howardjohn howardjohn marked this pull request as ready for review January 8, 2025 19:43
@howardjohn howardjohn requested a review from a team as a code owner January 8, 2025 19:43
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jan 8, 2025
@ilrudie ilrudie self-assigned this Jan 8, 2025
ilrudie
ilrudie approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@ilrudie ilrudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@istio-testing istio-testing merged commit eda6461 into istio:master Jan 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilrudie ilrudie ilrudie approved these changes

Assignees

@ilrudie ilrudie

Labels
release-notes-none Indicates a PR that does not require release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@howardjohn @istio-testing @ilrudie