Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Benchmark README.md to reflect actual options in runner.py #3117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Benchmark README.md to reflect actual options in runner.py #3117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions perf/benchmark/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ optional arguments:
config yaml file
--cacert CACERT path to the cacert for the fortio client inside the
container
--baseline run baseline for all
--no_baseline do not run baseline for all
--no_istio run baseline for all
--no_no_istio do not run baseline for all
--serversidecar run serversidecar-only for all
--no_serversidecar do not run serversidecar-only for all
--clientsidecar run clientsidecar-only for all
Expand Down Expand Up @@ -135,24 +135,24 @@ python runner/runner.py --config_file ./configs/istio/telemetryv2_stats/latency.
### Example 2

```bash
python runner/runner.py --conn 2,4,8,16,32,64 --qps 1000 --duration 240 --baseline --load_gen_type=fortio --telemetry_mode=v2-nullvm
python runner/runner.py --conn 2,4,8,16,32,64 --qps 1000 --duration 240 --no_istio --load_gen_type=fortio --telemetry_mode=v2-nullvm
```

- This will run separate tests for the `both` and `baseline` modes with fortio as the load generator and testing telemetryv2 enabled scenario
- This will run separate tests for the `both` and `no_istio` (baseline) modes with fortio as the load generator and testing telemetryv2 enabled scenario
- Separate tests for 2 to 64 concurrent connections
- All connections will send a total of **1000** QPS
- Each test will run for **240** seconds

### Example 3

```bash
python runner/runner.py --conn 16,64 --qps 1000,4000 --duration 180 --serversidecar --baseline --load_gen_type=nighthawk --telemetry_mode=none
python runner/runner.py --conn 16,64 --qps 1000,4000 --duration 180 --serversidecar --no_istio --load_gen_type=nighthawk --telemetry_mode=none
```

- 12 tests total, each for **180** seconds, with all combinations of:
- **16** and **64** connections
- **1000** and **4000** QPS
- `both`, `serversidecar`, and `baseline` modes
- `both`, `serversidecar`, and `no_istio` (baseline) modes

### Example 4

Expand Down