Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tools #3090

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

update tools #3090

wants to merge 4 commits into from
+582 −509

Conversation

jacob-delgado
Copy link
Contributor

minor fixes, putting dnm/hold until a bigger change (or # of tools is higher)

@jacob-delgado jacob-delgado added the do-not-merge/hold Block automatic merging of a PR. label Dec 11, 2024
@jacob-delgado jacob-delgado requested a review from a team as a code owner December 11, 2024 17:01
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 11, 2024
@jacob-delgado jacob-delgado removed the do-not-merge/hold Block automatic merging of a PR. label Dec 16, 2024
@istio-testing istio-testing added needs-rebase Indicates a PR needs to be rebased before being merged size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 16, 2024
@jacob-delgado
update tools
b6fcf34 
update dependencies
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Dec 16, 2024
@istio-testing istio-testing added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 16, 2024
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Dec 16, 2024
@istio-testing
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@istio-testing
Copy link
Contributor

@jacob-delgado: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
containers-test-arm64_tools dec9aa9 link true /test containers-test-arm64
lint_tools dec9aa9 link true /test lint
containers-test_tools dec9aa9 link true /test containers-test
build_tools dec9aa9 link true /test build
test_tools dec9aa9 link true /test test
gencheck_tools dec9aa9 link true /test gencheck

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-rebase Indicates a PR needs to be rebased before being merged size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacob-delgado @istio-testing