Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.23] Fix tcp telemetry for service-oriented waypoints #6036

Open
wants to merge 3 commits into
base: release-1.23
Choose a base branch
from
Open

[release-1.23] Fix tcp telemetry for service-oriented waypoints #6036

wants to merge 3 commits into from
+399 −83

Conversation

keithmattix
Copy link
Contributor

Cherrypick of #5968

@keithmattix
Fix tcp telemetry for service-oriented waypoints
35f36ee 
The metadata_exchange filter only looks at downstream metadata; this PR configures it to check upstream metadata and store it in filter state (with the appropriate key) if it exists. Note that workload oriented waypoints are still broken because those endpoints have no metadata.
@keithmattix keithmattix requested a review from a team as a code owner December 31, 2024 19:11
@keithmattix keithmattix changed the title [release-1.3] Fix tcp ambient metrics [release-1.23] Fix tcp ambient metrics Dec 31, 2024
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 31, 2024
@keithmattix keithmattix changed the title [release-1.23] Fix tcp ambient metrics [release-1.23] Fix tcp telemetry for service-oriented waypoints Dec 31, 2024
@keithmattix
Change metadata key
e40e209 
Signed-off-by: Keith Mattix II <[email protected]>
@keithmattix
Fixup
5c7142a 
Signed-off-by: Keith Mattix II <[email protected]>
@istio-testing
Copy link
Collaborator

@keithmattix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
test-arm-arm64_proxy_release-1.23 5c7142a link true /test test-arm-arm64
release-test-arm64_proxy_release-1.23 5c7142a link true /test release-test-arm64
test_proxy_release-1.23 5c7142a link true /test test
test-asan_proxy_release-1.23 5c7142a link true /test test-asan
release-test_proxy_release-1.23 5c7142a link true /test release-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keithmattix @istio-testing