Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MX support additional labels #6030

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

MX support additional labels #6030

wants to merge 5 commits into from
+679 −69

Conversation

zirain
Copy link
Member

@zirain zirain commented Dec 29, 2024 •
edited
Loading

@istio-testing
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-testing istio-testing added do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 29, 2024
@zirain zirain changed the title Mx labels [WIP] support additional labels Dec 29, 2024
@zirain
Copy link
Member Author

zirain commented Dec 30, 2024

/test all

@istio-testing istio-testing added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 30, 2024
@zirain
Copy link
Member Author

zirain commented Dec 30, 2024

/test all

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Dec 30, 2024
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Dec 30, 2024
@zirain
Copy link
Member Author

zirain commented Dec 30, 2024

/test all

1 similar comment
@zirain
Copy link
Member Author

zirain commented Dec 30, 2024

/test all

@zirain
Copy link
Member Author

zirain commented Jan 1, 2025

/test all

@zirain zirain changed the title [WIP] support additional labels support additional labels Jan 1, 2025
@zirain zirain changed the title support additional labels MX support additional labels Jan 1, 2025
@zirain zirain marked this pull request as ready for review January 1, 2025 08:54
@zirain zirain requested a review from a team as a code owner January 1, 2025 08:54
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jan 1, 2025
@istio-testing
Copy link
Collaborator

@zirain: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
test-arm-arm64_proxy 7cbf10b link true /test test-arm-arm64
test-asan_proxy 7cbf10b link true /test test-asan
test_proxy 7cbf10b link true /test test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zirain @istio-testing @howardjohn