Skip to content

Update core-js to latest version #16518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2025
Merged

Update core-js to latest version #16518

merged 1 commit into from
May 26, 2025

Conversation

Ajay-singh1
Copy link
Contributor

@Ajay-singh1 Ajay-singh1 commented May 24, 2025 •
edited
Loading

Description

This PR updates the core-js version to the latest version which is version 3.42.0

Attached Screenshot which shows clean site build without any error or conflicts:-

Screenshot from 2025-05-24 19-18-19

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@Ajay-singh1 Ajay-singh1 requested a review from a team as a code owner May 24, 2025 14:22
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels May 24, 2025
@istio-testing
Copy link
Contributor

Hi @Ajay-singh1. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dhawton
Copy link
Member

dhawton commented May 24, 2025

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels May 24, 2025
@craigbox
Copy link
Contributor

I'll merge this, but I would like to understand what core-js is used for and why it's installed separately - it's not listed in https://github.com/istio/tools/blob/master/docker/build-tools/Dockerfile.

@istio-testing istio-testing merged commit bc6e6d6 into istio:master May 26, 2025
6 checks passed
@Ajay-singh1
Copy link
Contributor Author

core-js is used by babel as a dependency.At first I thought that this package was unnecessary because I didn't find it in the build tools. Is it a good idea to include this in istio/tools? @craigbox

@craigbox
Copy link
Contributor

craigbox commented May 28, 2025 •
edited
Loading

Look at gen_site.sh in the scripts directory - you'll see what Babel is used for.

Does it need to be installed separately? I guess not, it hasn't been to date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigbox craigbox craigbox approved these changes

Assignees
No one assigned
Labels
area/environments area/networking ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ajay-singh1 @istio-testing @dhawton @craigbox @istio-policy-bot