-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Azure Load Balancer notes #16456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Azure Load Balancer notes #16456
Conversation
Skipping CI for Draft Pull Request. |
todo, add a section on infra labels |
@@ -61,6 +61,14 @@ bookinfo-gateway istio bookinfo-gateway-istio.default.svc.cluster.local Tr | |||
|
|||
Wait for the gateway to show as programmed before continuing. | |||
|
|||
{{< tip >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We try very hard to keep the Getting Started guides to be simple, and not full of "if this then that'. Is there any other way we can communicate this to keep it out of the "happy path"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair. I was going to justify it by saying "we do similar stuff for GKE", but I think I hallucinated that. We definitely want to add something on in the Azure specific section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aha! I found it: https://istio.io/latest/docs/examples/bookinfo/#start-the-application-services. Though I agree that this is not be a good precendent to follow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same requirement is probably true of AKS, which probably didn't exist when the page was written 🤣
@Stevenjin8: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Band aid for istio/istio#46769
Reviewers