Skip to content

Azure Load Balancer notes #16456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Stevenjin8
Copy link
Contributor

Description

Band aid for istio/istio#46769

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@istio-testing
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-testing istio-testing added do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 7, 2025
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 7, 2025
@Stevenjin8 Stevenjin8 marked this pull request as ready for review May 9, 2025 19:39
@Stevenjin8 Stevenjin8 requested a review from a team as a code owner May 9, 2025 19:39
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label May 9, 2025
@Stevenjin8
Copy link
Contributor Author

todo, add a section on infra labels

@@ -61,6 +61,14 @@ bookinfo-gateway istio bookinfo-gateway-istio.default.svc.cluster.local Tr

Wait for the gateway to show as programmed before continuing.

{{< tip >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try very hard to keep the Getting Started guides to be simple, and not full of "if this then that'. Is there any other way we can communicate this to keep it out of the "happy path"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair. I was going to justify it by saying "we do similar stuff for GKE", but I think I hallucinated that. We definitely want to add something on in the Azure specific section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aha! I found it: https://istio.io/latest/docs/examples/bookinfo/#start-the-application-services. Though I agree that this is not be a good precendent to follow

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same requirement is probably true of AKS, which probably didn't exist when the page was written 🤣

@istio-testing
Copy link
Contributor

istio-testing commented May 16, 2025

@Stevenjin8: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
doc.test.profile-demo_istio.io b741c88 link true /test doc.test.profile-demo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants