-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Migrated the Ruby Linter to NodeJS Linter #16316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
473a58d
a7288b4
af0164e
f6464eb
0c58b64
e3e7746
9eb6f61
6c6d451
100d387
58d834c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
{ | ||
"default": false, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this turn off the default rules? Wouldn't we want them on? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes this will turn off the default rules , no turning them on is not a good way because all the rules will be applied by default which is used by the linter and we dont want them right?We will explicitly define the rules which we want to use to lint our markdown files. |
||
"MD002": { "level": 2 }, | ||
"MD007": { "indent": 4 }, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This rule is disabled in many files. Can you look into why they are failing, and if we can just change the markup to pass correctly? Did we not have this rule in the old config? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We did have this rule in the old configuration.It is failing because markdownlint-cli2 enforces strict MD007 rules while the previous linter allows for mixed indentation for the MD007 rule.Changing markup will have several breaking changes. |
||
"MD013": false, | ||
"MD026": { "punctuation": ".,;:!" }, | ||
"MD014": false, | ||
"MD030": false, | ||
"MD032": false, | ||
"MD033": false, | ||
"MD041": false, | ||
"MD046": false | ||
} |
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.