-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow overriding prev and next links in frontmatter (#15755) #16044
base: master
Are you sure you want to change the base?
Conversation
😊 Welcome! This is either your first contribution to the Istio documentation repo, or
Thanks for contributing! Courtesy of your friendly welcome wagon. |
Hi @AdeshGhadage. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
There was a build failure here, so this PR is not yet ready for review. |
I have solved build failure, I am new to istio. any more changed needed? |
A brief look at this suggests it isn't going to work how we need. Also, we don't have a |
Thanks adesh! It looks like it might work but I suspect you've changed which of "next" and "prev" are left and right. To make the testing easier, it would be worth setting up a couple of next: and prev: in the front matter of some pages. Where I would explicitly suggest you put them: then |
@craigbox The difficulty I faced stemmed from not fully understanding Hugo's multilingual mode. Initially, I tried to provide the URL for a specific language version directly to Site.GetPage, but this didn't work because Hugo resolves paths based on the current language. After learning about multilingual support, I realized I needed to handle language-specific pages properly by including the correct language code in the path. Once I figured this out, I was able to resolve the issue and successfully implement the functionality. I enjoyed learning a lot while solving this challenge! |
LGTM; it's there in EN, it's not there in ZH, it does what we wanted. I'll approve this once the requested change is made. but I would like to encourage you to think about if there is a way to automate this: if you're on a page with children, then 'next' should be the first child, and the 'prev' should be the last page in the bundle from before. Don't think too hard, but this demonstrates good pre-work for an upcoming mentorship :) |
@@ -8,6 +8,7 @@ aliases: | |||
owner: istio/wg-environment-maintainers | |||
test: n/a | |||
list_below: yes | |||
prev: /docs/ambient/getting-started/cleanup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thoughts we should remove this; people who find this page don't necessarily come from Getting Started.
prev: /docs/ambient/getting-started/cleanup |
I currently out on vacation i will do the changes as soon as i get back |
No rush, thanks. |
Description
This pull request introduces a feature allowing content authors to override the prev and next navigation links directly in the front matter of a Hugo page. This PR addresses issue #15755
Reviewers