Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the typeface used on istio.io #15853

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

craigbox
Copy link
Contributor

I find our current body typeface, Barlow, a bit hard to read, at least at the weights we use it.
It also has unfixed kerning issues.

This PR experiments with changing it - I have picked Inter as a modern web-friendly option, so we can start seeing what it might look like, and consider what weights we would need to adjust.

@craigbox craigbox requested a review from a team as a code owner October 31, 2024 01:27
@craigbox craigbox added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Oct 31, 2024
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2024
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2024
@ilrudie
Copy link
Contributor

ilrudie commented Oct 31, 2024

subtle difference but I like it, TY

@Andygol
Copy link
Contributor

Andygol commented Dec 2, 2024

🤞 I hope new font supports Cyrillic

@craigbox
Copy link
Contributor Author

craigbox commented Dec 2, 2024

Does Barlow not?
Can we add another font to fall back to, for Cyrillic characters?

@Andygol
Copy link
Contributor

Andygol commented Dec 3, 2024

According to https://fonts.google.com/specimen/Barlow/glyphs, Barlow has no support for scripts other than Latin. Inter (https://fonts.google.com/specimen/Inter/glyphs) supports Latin, Greek, and Cyrillic.

@craigbox
Copy link
Contributor Author

craigbox commented Dec 3, 2024

We're already using Barlow, and you have a site in Ukrainian, which uses the Cyrillic alphabet...?

Is it using one of the fallback fonts?

@Andygol
Copy link
Contributor

Andygol commented Dec 3, 2024

If you compare English version and Ukrainian, you will see differences in glyphs such as "e" (Lat) and "е" (Cyr) on the screenshots, width of letters is different and so on. And, yes, Ukrainian version use some fallback font.

istio.io istio.io/latest/uk/
image image

@istio-testing
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. needs-rebase Indicates a PR needs to be rebased before being merged size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants