codegen: fix DeepCopy races #2322
Open
+7
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes istio/api#3019 The deepcopygen we use is from Kubernetes. Its not quite suitable for our types due to our usage of protobuf, which has limitations on dereferencing pointer types. This causes race conditions in concurrent usage of the DeepCopy function. This is possible to trigger with real Istio (found by running Istio in a live cluster with `-race`, though our current tests happen to not trigger things I guess), as well as other usage of istio/client-go (as the reporter found). I ran istio/istio with this change and found all tests continue to pass, and running in a live cluster no longer fails
howardjohn
added
the
cherrypick/release-1.24
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
|
😊 Welcome @howardjohn! This is either your first contribution to the Istio client-go repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
istio-testing
added
the
size/XS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes istio/api#3019
The deepcopygen we use is from Kubernetes. Its not quite suitable for our types due to our usage of protobuf, which has limitations on dereferencing pointer types. This causes race conditions in concurrent usage of the DeepCopy function.
This is possible to trigger with real Istio (found by running Istio in a live cluster with
-race, though our current tests happen to not trigger things I guess), as well as other usage of istio/client-go (as the reporter found).I ran istio/istio with this change and found all tests continue to pass, and running in a live cluster no longer fails