Add Claude Code command for updating EOL Istio versions #1326
Conversation
Adds a custom Claude Code slash command (/update-eol-versions) that automates the process of marking End-of-Life Istio versions in versions.yaml. The command fetches the current supported versions from istio.io and updates the EOL status accordingly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Filip Brychta <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1326 +/- ##
==========================================
+ Coverage 77.69% 79.11% +1.41%
==========================================
Files 44 44
Lines 2834 2255 -579
==========================================
- Hits 2202 1784 -418
+ Misses 524 365 -159
+ Partials 108 106 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| - Only mark versions as EOL if they are confirmed to be EOL upstream | ||
| - Preserve all existing version entries - do not remove them from the file | ||
| - The `eol: true` flag makes versions uninstallable but keeps them as valid spec.version values for API compatibility | ||
| - After marking as EOL, the charts array should be removed since EOL versions don't need chart URLs |
There was a problem hiding this comment.
I guess not just the charts array but all fields except name and eol, right?
There was a problem hiding this comment.
It's doing that even with current steps but for sure it will be better to be more specific. I will update this. Thanks!
|
Cool idea! |
Signed-off-by: Filip Brychta <[email protected]>
sridhargaddam
left a comment
sridhargaddam
left a comment
There was a problem hiding this comment.
LGTM, nice @FilipB
Added a /hold so that others can take a look. Feel free to remove it if required.
fjglira
left a comment
fjglira
left a comment
There was a problem hiding this comment.
Only a small comment, but I really like this. We should add a note in the release issue to execute this to get the EOL version
| - If a version has `eol: true` but is still supported upstream, remove the `eol: true` flag (this handles corrections) | ||
| - Preserve the YAML structure and comments | ||
| - For EOL versions, keep only `name:`, `eol:` and `ref:` sections | ||
|
|
|
|
||
| ## Important Notes | ||
|
|
||
| - Only mark versions as EOL if they are confirmed to be EOL upstream |
There was a problem hiding this comment.
To avoid some errors, we should specify what is upstream and give Claude the URL for the repository that we consider upstream in this case. In this maybe we should said something like
| - Only mark versions as EOL if they are confirmed to be EOL upstream | |
| - Only mark versions as EOL if they are confirmed to be EOL upstream Istio [project](https://istio.io/latest/docs/releases/supported-releases/) |
| - Preserve all existing version entries - do not remove them from the file | ||
| - The `eol: true` flag makes versions uninstallable but keeps them as valid spec.version values for API compatibility | ||
| - For EOL versions, keep only `name:`, `eol:` and `ref:` sections | ||
| - Always verify the changes before committing |
There was a problem hiding this comment.
| - Always verify the changes before committing | |
| - Show the changes and ask the user to confirm the changes before committing |
Maybe be more specific to avoid different kinds of results
5 participants
Adds a custom Claude Code slash command (/update-eol-versions) that automates the process of marking End-of-Life Istio versions in versions.yaml. The command fetches the current supported versions from istio.io and updates the EOL status accordingly.
🤖 Generated with Claude Code