Skip to content

Commit

Permalink
ci: migrate to nodejs v20
Browse files Browse the repository at this point in the history
  • Loading branch information
isqua committed Jul 23, 2023
1 parent c492f42 commit 719f2dd
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: install dependencies
run: npm ci
- name: build app
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: install dependencies
run: npm ci
- name: lint
Expand All @@ -26,6 +26,6 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
- name: run audit
run: npm audit --production
6 changes: 3 additions & 3 deletions src/features/FormGenerator/FormGenerator.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ describe('features/FormGenerator', () => {

it('should render error but not rerender form when text is not a valid JSON', () => {
const value = '{"title":"hello';
const expectedError = 'Unexpected end of JSON input';
const expectedError = 'Unterminated string in JSON at position 15';

render(<FormGenerator />);
fireEvent.change(
Expand Down Expand Up @@ -109,7 +109,7 @@ describe('features/FormGenerator', () => {
screen.getByLabelText(formJsonInputLabel),
{ target: { value: userValue } },
);
expect(screen.getByText('Unexpected end of JSON input')).toBeInTheDocument();
expect(screen.getByText('Unterminated string in JSON at position 1')).toBeInTheDocument();

fireEvent.click(screen.getByRole('button', { name: 'Example' }));
const actual = JSON.parse(screen.getByLabelText<HTMLTextAreaElement>(formJsonInputLabel).value);
Expand Down Expand Up @@ -173,7 +173,7 @@ describe('features/FormGenerator', () => {
jest.runAllTimers();

await waitFor(
() => expect(screen.getByText('Unexpected end of JSON input')).toBeInTheDocument(),
() => expect(screen.getByText('Unterminated string in JSON at position 1')).toBeInTheDocument(),
);

fireEvent.click(screen.getByRole('button', { name: 'Rollback' }));
Expand Down

0 comments on commit 719f2dd

Please sign in to comment.