Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Included unused var.manage_aws_auth_configmap #45

Merged
merged 1 commit into from
May 30, 2024
Merged

Included unused var.manage_aws_auth_configmap #45

merged 1 commit into from
May 30, 2024

Conversation

PhilipSchmid
Copy link
Contributor

var.manage_aws_auth_configmap was never actually used.

@darox
Copy link
Contributor

darox commented May 27, 2024

Thank you @PhilipSchmid shall I cut a new release?

ttarczynski
ttarczynski approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@ttarczynski ttarczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhilipSchmid
Copy link
Contributor Author

Cutting a new release sounds good, but maybe approve and merge the two other dependabot PRs first. 🙏

@PhilipSchmid PhilipSchmid merged commit dd2d14f into main May 30, 2024
2 checks passed
@PhilipSchmid PhilipSchmid deleted the pr/philip/fix_aws_auth_cm_usage branch May 30, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttarczynski ttarczynski ttarczynski approved these changes

@darox darox darox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PhilipSchmid @darox @ttarczynski