Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #126
constructor(...)
method from the interface. When user provides a customdb
instance, the constructor is never invoked by the lightning-fs so constraining it in the interface is unnecessary. Please confirm this though. In addition, if we want to constrain the constructor interface, (for whatever reason), a different setup is required. See: https://stackoverflow.com/questions/13407036/how-does-interfaces-with-construct-signatures-workloadFile
toreadFile
, matching implemention.