Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ios build Fails in Xcode 15 with React Native 0.74.0 #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kadarsh11
Copy link

@kadarsh11 kadarsh11 commented Jul 4, 2024

This change resolves build fails issue by implementing the new native module method architecture

https://reactnative.dev/docs/native-modules-ios#create-custom-native-module-files

Error log

❌  /Users/[REDACTED]/git/node_modules/react-native/React/Base/RCTBridgeModule.h:151:56: expected ';' at end of declaration list

@property (nonatomic, weak, readonly) RCTBridge *bridge RCT_DEPRECATED;
          ^

❌  /Users/[REDACTED]/git/node_modules/react-native/React/Base/RCTBridgeModule.h:151:57: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]

@property (nonatomic, weak, readonly) RCTBridge *bridge RCT_DEPRECATED;
                                                       ^
❌  /Users/[REDACTED]/git/node_modules/react-native/React/Base/RCTBridgeModule.h:164:69: expected ';' at end of declaration list

@property (nonatomic, strong, readonly) dispatch_queue_t methodQueue RCT_DEPRECATED;
                                                        ^



❌  /Users/[REDACTED]/git/node_modules/react-native/React/Base/RCTBridgeModule.h:164:70: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]

@property (nonatomic, strong, readonly) dispatch_queue_t methodQueue RCT_DEPRECATED;
                                                                    ^



❌  /Users/[REDACTED]/git/node_modules/react-native/React/Base/RCTBridgeModule.h:151:57: cannot declare variable inside @interface or @protocol

@property (nonatomic, weak, readonly) RCTBridge *bridge RCT_DEPRECATED;
                                                                     ^



❌  /Users/[REDACTED]/git/node_modules/react-native/React/Base/RCTBridgeModule.h:164:70: cannot declare variable inside @interface or @protocol

@property (nonatomic, strong, readonly) dispatch_queue_t methodQueue RCT_DEPRECATED;
                                                        ^



❌  /Users/[REDACTED]/git/node_modules/react-native/React/Base/RCTBridgeModule.h:366:1: duplicate interface definition for class 'RCTModuleRegistry'

@interface RCTModuleRegistry : NSObject
                                                                     ^



❌  /Users/[REDACTED]/git/node_modules/react-native/React/Base/RCTBridgeModule.h:382:1: duplicate interface definition for class 'RCTViewRegistry'

@interface RCTViewRegistry : NSObject
           ^



❌  /Users/[REDACTED]/git/node_modules/react-native/React/Base/RCTBridgeModule.h:400:1: duplicate interface definition for class 'RCTCallableJSModules'

@interface RCTCallableJSModules : NSObject
           ^

@kadarsh11 kadarsh11 changed the title Feat: Added new module implementation Ios build Fails in Xcode 15 with React Native 0.74.0 Jul 4, 2024
@kadarsh11
Copy link
Author

@ismaeldcom Can you please review this. I see this library have no update this last 4yr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant