Merge branch '2744-warning-checkhints-unable-to-get-root-ns-rrset-fro…

…m-cache-not-found-9.18' into 'bind-9.18'

[9.18] Resolve "warning: checkhints: unable to get root NS rrset from cache: not found"

See merge request isc-projects/bind9!9080

CHANGES

@@ -9,6 +9,9 @@
 6393.	[func]		Deal with uv_tcp_close_reset() error return codes
 			more gracefully. [GL #4708]
 
+6392.	[bug]		Use a completely new memory context when flushing the
+			cache. [GL #2744]
+
 6391.	[bug]		TCP client statistics could sometimes fail to decrease
 			when accepting client connection fails. [GL #4742]
 

bin/named/server.c

@@ -4740,21 +4740,11 @@ configure_view(dns_view_t *view, dns_viewlist_t *viewlist, cfg_obj_t *config,
 			 * view but is not yet configured.  If it is not the
 			 * view name but not a forward reference either, then it
 			 * is simply a named cache that is not shared.
-			 *
-			 * We use two separate memory contexts for the
-			 * cache, for the main cache memory and the heap
-			 * memory.
 			 */
-			isc_mem_create(&cmctx);
-			isc_mem_setname(cmctx, "cache");
-			isc_mem_create(&hmctx);
-			isc_mem_setname(hmctx, "cache_heap");
-			CHECK(dns_cache_create(cmctx, hmctx, named_g_taskmgr,
+			CHECK(dns_cache_create(mctx, named_g_taskmgr,
 					       named_g_timermgr, view->rdclass,
 					       cachename, "rbt", 0, NULL,
 					       &cache));
-			isc_mem_detach(&cmctx);
-			isc_mem_detach(&hmctx);
 		}
 		nsc = isc_mem_get(mctx, sizeof(*nsc));
 		nsc->cache = NULL;