Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[colorize_nicks] Case sensitive selection #808

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

capitaineplanete
Copy link
Contributor

make colorise_nicks case sensitive

make colorise_nicks case sensitive
@ailin-nemui
Copy link
Contributor

why?

@capitaineplanete
Copy link
Contributor Author

capitaineplanete commented Apr 27, 2022

so may false positives, at least in my experience. Besides most if not all clients match nick case in tab completion.

I mean look at this... :P most of which are the same word repeated.

EDIT: it is rare that people write out the nicks of those they're trying to highlight, usually that's the clients job. and since many people choose nicks that usually consist of common words it becomes frustrating when these words are treated as coloured nicks and not as words especially mid sentence.

Screenshot 2022-04-27 at 10 35 52

@ailin-nemui
Copy link
Contributor

from my understanding your patch will not change anything. but maybe I'm wrong

@capitaineplanete
Copy link
Contributor Author

you're right my tests weren't as thorough. I'm making a few changes and will add an option to opt in. I don't really perl I'm just following the control flow of the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants