Update quitrand.pl #716
Open
Update quitrand.pl #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up the perl a little. Remove an uneccesary loop, use a lexical file handle to avoid possible conflicts, and use chomp instead of chop. chomp will only remove the newline rather than any last character in the line. This fixes a potential bug for the last message in the file if the file doesn't end in a newline.
bump the version of the script
|
it would seem that the array index can go out of the end of lines? |
|
It's been a while since I've used irssi (or IRC for that matter). I'm amazed someone is even caring about quitrand.pl at all! |
|
No idea if anyone uses it but it came up when someone wanted to script separate quit messages for each network :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the perl a little. Remove an uneccesary loop, use a lexical file handle to avoid possible conflicts, and use chomp instead of chop. chomp will only remove the newline rather than any last character in the line. This fixes a potential bug for the last message in the file if the file doesn't end in a newline.