Activate administrators #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danigargar
force-pushed
the
CDD-4-activate-administrators
branch
from
0797738
to
5fb328e
Compare
danigargar
changed the base branch from
main
to
CDD-2-add-email-to-administrator
danigargar
force-pushed
the
CDD-4-activate-administrators
branch
2 times, most recently
from
0e87f32
to
72dffd6
Compare
danigargar
force-pushed
the
CDD-4-activate-administrators
branch
4 times, most recently
from
ea34d63
to
4810bea
Compare
mmadariaga
suggested changes
Feb 7, 2024
app/src/Demo/Domain/Service/Administrator/SendActivationEmail.php
Outdated
Show resolved
Hide resolved
app/src/Demo/Domain/Service/Administrator/SendActivationEmail.php
Outdated
Show resolved
Hide resolved
app/src/Demo/Domain/Service/Administrator/SendActivationEmail.php
Outdated
Show resolved
Hide resolved
app/src/Demo/Domain/Service/Administrator/SendActivationEmail.php
Outdated
Show resolved
Hide resolved
app/src/Demo/Domain/Service/Administrator/SetActiveInterface.php
Outdated
Show resolved
Hide resolved
danigargar
force-pushed
the
CDD-4-activate-administrators
branch
4 times, most recently
from
eed0368
to
2e7d2d2
Compare
mmadariaga
suggested changes
Feb 9, 2024
app/src/Demo/Domain/Service/Administrator/SendActivationEmail.php
Outdated
Show resolved
Hide resolved
app/src/Demo/Infrastructure/Service/Administrator/SendActivationEmail.php
Outdated
Show resolved
Hide resolved
danigargar
force-pushed
the
CDD-4-activate-administrators
branch
6 times, most recently
from
0b1e381
to
7d5f5e7
Compare
mmadariaga
suggested changes
Feb 19, 2024
app/src/Demo/Domain/Service/Administrator/SendActivationEmail.php
Outdated
Show resolved
Hide resolved
mmadariaga
reviewed
Feb 19, 2024
danigargar
force-pushed
the
CDD-4-activate-administrators
branch
from
7d5f5e7
to
110a400
Compare
danigargar
force-pushed
the
CDD-4-activate-administrators
branch
from
110a400
to
b3436b5
Compare
mmadariaga
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you create an administrator (lifecycle), send an email to his email with an activation link.
This link has to lead to a page that activates the admin (let's ignore security mechanisms here).
Add to the API the
/administrator/{id}/send_activation_emailendpoint that allows to send the email manually.