Remove a couple of private property setters in OLEPropertiesContainer #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numpsy
changed the title
Numpsy
commented
Oct 5, 2024
| @@ -126,8 +126,6 @@ internal OLEPropertiesContainer(CFStream cfStream) | |||
| UserDefinedProperties = new OLEPropertiesContainer(pStream.PropertySet1.PropertyContext.CodePage, ContainerType.UserDefinedProperties); | |||
| HasUserDefinedProperties = true; | |||
|
|
|||
| UserDefinedProperties.ContainerType = ContainerType.UserDefinedProperties; | |||
There was a problem hiding this comment.
The ContainerType property in OLEPropertiesContaineris set to the value passed into the constructor, so I don't think it needs to be set here as well
There was a problem hiding this comment.
could remove this line without the other changes though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling in a couple of minor changes from my other PRs - I don't think these would be counted as API changes as they're private anyway, but that can be confirmed by others.
I don't think these should be settable - ContainerType is set on consturction and I don't think you'd want to change that afterwards, and I don't think there is a need for the context to be replaced - the properties inside it can be changed if needed