Don't incur the penalty of validation if it's disabled. Also combin C…

…ontains with Add
ironfede · May 31, 2024 · ab465fa · ab465fa
1 parent a61b6b9
commit ab465fa
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/sources/OpenMcdf/CompoundFile.cs b/sources/OpenMcdf/CompoundFile.cs
@@ -1367,12 +1367,15 @@ int nextSecID
 
         private void EnsureUniqueSectorIndex(int nextSecID, HashSet<int> processedSectors)
         {
-            if (processedSectors.Contains(nextSecID) && this.validationExceptionEnabled)
+            if (!this.validationExceptionEnabled)
             {
-                throw new CFCorruptedFileException("The file is corrupted.");
+                return;
             }
 
-            processedSectors.Add(nextSecID);
+            if (!processedSectors.Add(nextSecID))
+            {
+                throw new CFCorruptedFileException("The file is corrupted.");
+            }
         }
 
         /// <summary>