Skip to content

Commit

Permalink
Read data for PropertyIdentifierAndOffset using the Read() member fun…
Browse files Browse the repository at this point in the history
…ction

Just a thought - the code coverage report shows the Read() function as unused (the Write function is used for writes, so this is maybe a bit more consistent)
  • Loading branch information
Numpsy authored and jeremy-visionaid committed Nov 19, 2024
1 parent 1a9b982 commit 0e8ecab
Showing 1 changed file with 4 additions and 10 deletions.
14 changes: 4 additions & 10 deletions OpenMcdf.Ole/PropertySetStream.cs
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,8 @@ public void Read(BinaryReader br)
// Read property offsets (P0)
for (int i = 0; i < propertyCount; i++)
{
PropertyIdentifierAndOffset pio = new()
{
PropertyIdentifier = br.ReadUInt32(),
Offset = br.ReadUInt32()
};
PropertyIdentifierAndOffset pio = new();
pio.Read(br);
PropertySet0.PropertyIdentifierAndOffsets.Add(pio);
}

Expand Down Expand Up @@ -92,11 +89,8 @@ public void Read(BinaryReader br)
// Read property offsets
for (int i = 0; i < propertyCount; i++)
{
PropertyIdentifierAndOffset pio = new()
{
PropertyIdentifier = br.ReadUInt32(),
Offset = br.ReadUInt32()
};
PropertyIdentifierAndOffset pio = new();
pio.Read(br);
PropertySet1.PropertyIdentifierAndOffsets.Add(pio);
}

Expand Down

0 comments on commit 0e8ecab

Please sign in to comment.