-
Notifications
You must be signed in to change notification settings - Fork 98
update: adds testing for CELL, INFO, N, SHEET and SHEETS #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
nhatcher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @elsaminsut ,
Thanks for this! Do you think you can split the test file in 3 different ones?
N
Shheet and sheets
Cell
I think it is fine to group functions together if they belong together. Also if there are already some other files with smoke tests that are already covered here you can delete them
You can see the failing tests split per function in #533 |
Thanks. In this PR can you split the test case in different files also? |
bf11902 to
1a2f3df
Compare
Fixed! |
This PR adds testing for the CELL, INFO, N, SHEET and SHEETS functions. These include both xlsx tests with edge cases and unit tests to check the number of arguments taken by the function. It also includes an update to the main Information documentation page and their individual pages to show them as now available.
This PR closes #515
(See failing edge cases in #533)