Skip to content

Conversation

@elsaminsut
Copy link
Contributor

This PR adds testing for the CELL, INFO, N, SHEET and SHEETS functions. These include both xlsx tests with edge cases and unit tests to check the number of arguments taken by the function. It also includes an update to the main Information documentation page and their individual pages to show them as now available.

This PR closes #515

(See failing edge cases in #533)

Copy link
Member

@nhatcher nhatcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @elsaminsut ,

Thanks for this! Do you think you can split the test file in 3 different ones?
N
Shheet and sheets
Cell

I think it is fine to group functions together if they belong together. Also if there are already some other files with smoke tests that are already covered here you can delete them

@elsaminsut
Copy link
Contributor Author

Hi @elsaminsut ,

Thanks for this! Do you think you can split the test file in 3 different ones?

N

Shheet and sheets

Cell

I think it is fine to group functions together if they belong together. Also if there are already some other files with smoke tests that are already covered here you can delete them

You can see the failing tests split per function in #533

@nhatcher
Copy link
Member

You can see the failing tests split per function in #533

Thanks. In this PR can you split the test case in different files also?
Ideally we would have 1 file per functions.

@elsaminsut
Copy link
Contributor Author

You can see the failing tests split per function in #533

Thanks. In this PR can you split the test case in different files also? Ideally we would have 1 file per functions.

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please test and create docs for N, SHEETS, INFO and CELL

2 participants