feat: add event emitter for diffs #375
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianHung
force-pushed
the
event-emitter-on-diffs
branch
from
30922f8 to
8c0cc9b
Compare
BrianHung
force-pushed
the
event-emitter-on-diffs
branch
from
8fcdd87 to
71d596b
Compare
nhatcher
reviewed
Jun 14, 2025
|
|
||
| model.onDiffs(() => { | ||
| // React to diff list updates | ||
| redraw(); |
There was a problem hiding this comment.
BrianHung@4da4bb7
BrianHung@2f5346a
Two downstream commits I would probably merge into this PR!
I realized diffs should be emitted as a list, and we should output a diff type to allow typescript to do discriminate unions better.
|
Hi @BrianHung is it ok if we close this in favour of #380 ? |
|
Yep; just opened this PR so if you wanted to do PR stacking, it was available (merging some PRs but not all). Closing in favor of #380. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows wasm-binding to listen to changes in diffs.
The original cargo build --release --verbose command fails because our codebase now includes WASM, Python, and Node.js bindings that have conflicting compilation requirements: WASM is single-threaded while native Rust is multi-threaded.
We split the build into separate steps for each binding type, using wasm-pack for WASM builds and adding required dependencies like python3-dev headers. This allows all binding types to build successfully without threading conflicts.
#380 is a downstream PR I would accept if you would also want cells to be emitted.