feat: return sheet name and index from newSheet #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianHung
added a commit
to BrianHung/IronCalc
that referenced
this pull request
Jun 13, 2025
nhatcher
requested changes
Jun 28, 2025
bindings/nodejs/src/user_model.rs
Outdated
| #[napi(js_name = "newSheet")] | ||
| pub fn new_sheet(&mut self) -> Result<()> { | ||
| self.model.new_sheet().map_err(to_js_error) | ||
| self.model.new_sheet().map(|_| ()).map_err(to_js_error) |
There was a problem hiding this comment.
We would want to return the name also here to be consistent.
|
|
||
| let result = NewSheetResult { name, sheet_index }; | ||
|
|
||
| serde_wasm_bindgen::to_value(&result).map_err(|e| to_js_error(e.to_string())) |
There was a problem hiding this comment.
Can you just return (name, index)? Maybe not I haven't tried.
There was a problem hiding this comment.
LMK if changes work for you!
|
Rebased against main and added a test for core and user_model. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: return sheet name and index from newSheet
The returned sheet_index can be directly used with other API methods like renameSheet() and setUserInput().