Make SUM and PRODUCT functions more consistent with Excel #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions convert their arguments to numbers except when they belong to a cell reference or range.
gian-hancock
force-pushed
the
sum_product_function_fix
branch
from
2b12ed1 to
8174d06
Compare
|
Hi @gian-hancock , thanks for taking care of this. Will review soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Excel the SUM and PRODUCT functions convert non numeric arguments. This PR updates IronCalc to do the same.
Notably, Excel does not convert values which are part a range or reference argument, this PR adds tests for this oddity (among other things).