WIP: Changes for the upcoming iron 0.7 release with hyper 0.12 #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains all the changes necessary for
staticfileto work with the newironcrate based onhyper0.12.However, the tests are not updated so far, as they need the crate
iron_testto be updated, which has not happend so far. Thus, I marked this PR as WIP for now, but if we want to release without updatingiron_test, we could also drop the tests for now.In order to get everything working, I copied the source of HttpDate from hyper 0.11 (src/hyper/header/shared/httpdate.rs). Since this crate and hyper are both MIT licensed, I hope this should pose no problem.