[???] Create custom keycloak image for testing #371
Conversation
Environment should be the same. Asymmetric keys are only good for 10 years I think. Remember to update before then!
|
Rebuild image again for sanity check. Take out of draft if good. |
|
Builds good. Any future config changes should likely only see the |
|
I think we can use #242 for this. |
|
242 feels good and right. |
| @@ -0,0 +1,18 @@ | |||
| FROM quay.io/keycloak/keycloak:latest as builder | |||
There was a problem hiding this comment.
Add comments above the FROM lines which explain what the whole section is for. The comments will also serve as separators for the multi-stage build.
| @@ -0,0 +1,18 @@ | |||
| FROM quay.io/keycloak/keycloak:latest as builder | |||
|
|
|||
| # Configure stuff | |||
There was a problem hiding this comment.
Please expand "stuff" into more words.
| ENV KEYCLOAK_ADMIN=admin | ||
| ENV KEYCLOAK_ADMIN_PASSWORD=admin | ||
|
|
||
| # Optimized build thing |
There was a problem hiding this comment.
Please expand on this. It's not clear what this means.
There was a problem hiding this comment.
Are there other options of interests to add/document in the Dockerfile?
It's fine if the answer is no.
There was a problem hiding this comment.
Add a few comments to the top of the file explaining what it's for on a high level.
There was a problem hiding this comment.
Please add a README to this directory which describes this component.
The top-level README for the repo can point to it where necessary.
Hmm, we should add a README to the /test directory in general. Then we don't need a README for each subdirectory under /test.
|
can make a test/README.md to keep it scoped, if that seems a good idea. |
| @@ -0,0 +1,16 @@ | |||
| FROM quay.io/keycloak/keycloak:latest as builder | |||
There was a problem hiding this comment.
Do we want to pin to a specific version to avoid incompatibility with a future release? Maybe latest is... good enough...
There was a problem hiding this comment.
Let's pin it. Debugging becomes more difficult when everyone is using different versions of a thing.
| # Standard entrypoint | ||
| ENTRYPOINT ["/opt/keycloak/bin/kc.sh"] |
There was a problem hiding this comment.
If this is the ENTRYPOINT of the base image, we probably don't need to override it here. Doesn't hurt, though.
The environment should start the same on every standup by using the realm export. Asymmetric keys are only good for 10 years, I think. Remember to update before then!