Skip to content

Commit

Permalink
[CI] Enable the tests for fx_importer in the CI (llvm#3168)
Browse files Browse the repository at this point in the history
Replace the torchdynamo e2e with the fx_importer e2e
  • Loading branch information
penguin-wwy authored Apr 16, 2024
1 parent ae47247 commit 10b6062
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 8 deletions.
7 changes: 3 additions & 4 deletions build_tools/ci/test_posix.sh
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,9 @@ case $torch_version in
# python -m e2e_testing.main --config=lazy_tensor_core -v
# echo "::endgroup::"

# TODO: There is one failing test in this group on stable. It could
# be xfailed vs excluding entirely.
echo "::group::Run TorchDynamo e2e integration tests"
python -m e2e_testing.main --config=torchdynamo -v
# TODO: Need to verify in the stable version
echo "::group::Run FxImporter e2e integration tests"
python -m e2e_testing.main --config=fx_importer -v
echo "::endgroup::"
;;
stable)
Expand Down
6 changes: 2 additions & 4 deletions build_tools/python_deploy/build_linux_packages.sh
Original file line number Diff line number Diff line change
Expand Up @@ -308,10 +308,8 @@ function test_in_tree() {
echo ":::: Run Onnx e2e integration tests"
python -m e2e_testing.main --config=onnx -v

# Dynamo is changing a lot in nightly versions, and thus the implementation
# tends to become incompatible to the stable version.
echo ":::: Run TorchDynamo e2e integration tests"
python -m e2e_testing.main --config=torchdynamo -v
echo ":::: Run FxImporter e2e integration tests"
python -m e2e_testing.main --config=fx_importer -v
;;
stable)
echo ":::: Test with stable torch"
Expand Down
3 changes: 3 additions & 0 deletions projects/pt1/e2e_testing/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,9 @@ def main():

# Report the test results.
failed = report_results(results, xfail_set, args.verbose, args.config)
if args.config == "torchdynamo":
print("\033[91mWarning: the TorchScript based dynamo support is deprecated. "
"The config for torchdynamo is planned to be removed in the future.\033[0m")
if args.ignore_failures:
sys.exit(0)
sys.exit(1 if failed else 0)
Expand Down
7 changes: 7 additions & 0 deletions projects/pt1/e2e_testing/xfail_sets.py
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,12 @@
"AtenIntTensorCharDtypeModule_basic",
"AtenItemFpOpModule_basic",
"AtenItemIntOpModule_basic",
"AtenMmQint8_basic",
"AtenMatmulQint8_basic",
"AtenMatmulQint8MV_basic",
"AtenMmQMixedSigni8_basic",
"AtenMatmulQMixedSigni8_basic",
"AtenMatmulQMixedSigni8Transpose_basic",
"AtenMmQuint8_basic",
"AtenSubFloatModule_basic",
"BincountMinlengthModule_basic",
Expand Down Expand Up @@ -474,6 +480,7 @@
"QuantizedMLP_basic",
"QuantizedNoLayer_basic",
"QuantizedSingleLayer_basic",
"QuantizedBatchedInputSingleLayer_basic",
"ReduceMaxAlongDimUnsignedInt_basic",
"ReduceMinAlongDimUnsignedInt_basic",
"RsubInt0d_NumToTensor_Module_basic",
Expand Down

0 comments on commit 10b6062

Please sign in to comment.