-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SDXL EulerDiscreteScheduler compilation test #19315
Conversation
Signed-off-by: saienduri <[email protected]>
from conftest import VmfbManager | ||
from pathlib import Path | ||
|
||
rocm_chip = os.getenv("ROCM_CHIP", default="gfx90a") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is ROCM_CHIP
always set in the builders? I think in test_unet.py is defaulted to gfx942, is there any reason we use gfx90a instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's always set as part of the workflow file, so runners always get gfx942. This default is more for end users. I just changed all defaults to gfx942, so it's consistent though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just a QQ
Signed-off-by: saienduri <[email protected]>
Nice, thanks for clean up :) |
Signed-off-by: saienduri <[email protected]>
This commit adds a compilation test for the scheduler used in sdxl. We can iterate on this and add some tests that runs the different functions as well (`run_initialize`, `run_scale`, `run_step`) and checks for accuracy. ci-exactly: build_packages, regression_test --------- Signed-off-by: saienduri <[email protected]>
This commit adds a compilation test for the scheduler used in sdxl. We can iterate on this and add some tests that runs the different functions as well (`run_initialize`, `run_scale`, `run_step`) and checks for accuracy. ci-exactly: build_packages, regression_test --------- Signed-off-by: saienduri <[email protected]> Signed-off-by: Giacomo Serafini <[email protected]>
This commit adds a compilation test for the scheduler used in sdxl. We can iterate on this and add some tests that runs the different functions as well (
run_initialize
,run_scale
,run_step
) and checks for accuracy.ci-exactly: build_packages, regression_test