Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDXL EulerDiscreteScheduler compilation test #19315

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

saienduri
Copy link
Collaborator

@saienduri saienduri commented Nov 27, 2024

This commit adds a compilation test for the scheduler used in sdxl. We can iterate on this and add some tests that runs the different functions as well (run_initialize, run_scale, run_step) and checks for accuracy.

ci-exactly: build_packages, regression_test

from conftest import VmfbManager
from pathlib import Path

rocm_chip = os.getenv("ROCM_CHIP", default="gfx90a")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ROCM_CHIP always set in the builders? I think in test_unet.py is defaulted to gfx942, is there any reason we use gfx90a instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's always set as part of the workflow file, so runners always get gfx942. This default is more for end users. I just changed all defaults to gfx942, so it's consistent though

Copy link
Collaborator

@raikonenfnu raikonenfnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just a QQ

Signed-off-by: saienduri <[email protected]>
@raikonenfnu
Copy link
Collaborator

Nice, thanks for clean up :)

Signed-off-by: saienduri <[email protected]>
@saienduri saienduri merged commit ee3797d into iree-org:main Nov 27, 2024
31 checks passed
Groverkss pushed a commit to Groverkss/iree that referenced this pull request Dec 1, 2024
This commit adds a compilation test for the scheduler used in sdxl. We
can iterate on this and add some tests that runs the different functions
as well (`run_initialize`, `run_scale`, `run_step`) and checks for
accuracy.

ci-exactly: build_packages, regression_test

---------

Signed-off-by: saienduri <[email protected]>
giacs-epic pushed a commit to giacs-epic/iree that referenced this pull request Dec 4, 2024
This commit adds a compilation test for the scheduler used in sdxl. We
can iterate on this and add some tests that runs the different functions
as well (`run_initialize`, `run_scale`, `run_step`) and checks for
accuracy.

ci-exactly: build_packages, regression_test

---------

Signed-off-by: saienduri <[email protected]>
Signed-off-by: Giacomo Serafini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants