[python] Overhaul iree.build console output and error handling. #19314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
stellaraccident
commented
Nov 27, 2024
stellaraccident
commented
- Status updates look more like what would be expected from something like ninja or bazel:
- Short update one liners wink past
- If some actions are taking a long time, a multi-line display is shown with the worst lagging ones
- Per action errors and dependence errors are now tracked in the build graph and reported correctly (vs triggering the last chance exception handler).
- The last chance exception handler for true program errors now prints its exception verbosely prior to blocking waiting for the executor to shutdown (this was causing exception swallowing).
ScottTodd
approved these changes
Nov 27, 2024
* Status updates look more like what would be expected from something like ninja or bazel: * Short update one liners wink past * If some actions are taking a long time, a multi-line display is shown with the worst lagging ones * Per action errors and dependence errors are now tracked in the build graph and reported correctly (vs triggering the last chance exception handler). * The last chance exception handler for true program errors now prints its exception verbosely prior to blocking waiting for the executor to shutdown (this was causing exception swallowing). Signed-off-by: Stella Laurenzo <[email protected]>
stellaraccident
force-pushed
the
python_build_console_pretty
branch
from
437dc53 to
10458a5
Compare
Groverkss
pushed a commit
to Groverkss/iree
that referenced
this pull request
Dec 1, 2024
…-org#19314) * Status updates look more like what would be expected from something like ninja or bazel: * Short update one liners wink past * If some actions are taking a long time, a multi-line display is shown with the worst lagging ones * Per action errors and dependence errors are now tracked in the build graph and reported correctly (vs triggering the last chance exception handler). * The last chance exception handler for true program errors now prints its exception verbosely prior to blocking waiting for the executor to shutdown (this was causing exception swallowing). Signed-off-by: Stella Laurenzo <[email protected]>
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
…-org#19314) * Status updates look more like what would be expected from something like ninja or bazel: * Short update one liners wink past * If some actions are taking a long time, a multi-line display is shown with the worst lagging ones * Per action errors and dependence errors are now tracked in the build graph and reported correctly (vs triggering the last chance exception handler). * The last chance exception handler for true program errors now prints its exception verbosely prior to blocking waiting for the executor to shutdown (this was causing exception swallowing). Signed-off-by: Stella Laurenzo <[email protected]> Signed-off-by: Giacomo Serafini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.